Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Index using context #15290

Merged
merged 15 commits into from
Aug 30, 2024
Merged

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Aug 19, 2024

Description

In 2.16, we enabled functionality to use context to create index templates. This goes a step ahead, and allows to create index using the context directly specified in index creation.

Related Issues

Resolves #12683

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request feature New feature or request Indexing Indexing, Bulk Indexing and anything related to indexing RFC Issues requesting major changes Roadmap:Ease of Use Project-wide roadmap label v2.16.0 Issues and PRs related to version 2.16.0 v2.17.0 labels Aug 19, 2024
Copy link
Contributor

❌ Gradle check result for a1b5efa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for e2363aa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan added the backport PRs or issues specific to backporting features or enhancments label Aug 20, 2024
Copy link
Contributor

❌ Gradle check result for 600acc1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1c53a98: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mgodwan mgodwan force-pushed the index-creation branch 2 times, most recently from 7884e1d to dbc11bc Compare August 20, 2024 13:14
Copy link
Contributor

❌ Gradle check result for 1cc4f20: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 79352e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7884e1d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for dbc11bc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7c2914d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 4e85e28: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 1b8fdf4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 6a6b51f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 2f9a2cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Copy link
Contributor

❌ Gradle check result for c860f7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

mgodwan and others added 2 commits August 29, 2024 16:59
Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Signed-off-by: Mohit Godwani <81609427+mgodwan@users.noreply.github.com>
@dblock
Copy link
Member

dblock commented Aug 29, 2024

Please don't forget to add context to https://github.com/opensearch-project/opensearch-api-specification.

@mgodwan
Copy link
Member Author

mgodwan commented Aug 29, 2024

Please don't forget to add context to https://github.com/opensearch-project/opensearch-api-specification.

Yes, I'm making the changes for the same :)

Copy link
Contributor

❕ Gradle check result for 247e240: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❕ Gradle check result for 9bc165c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Mohit Godwani <81609427+mgodwan@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for 58955b9: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Mohit Godwani <81609427+mgodwan@users.noreply.github.com>
Copy link
Contributor

✅ Gradle check result for f8455ea: SUCCESS

@shwetathareja shwetathareja merged commit e3f8a38 into opensearch-project:main Aug 30, 2024
35 of 36 checks passed
@mgodwan mgodwan added the backport 2.x Backport to 2.x branch label Aug 30, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15290-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e3f8a38601efb0b8269e7099fa10adb7c8191505
# Push it to GitHub
git push --set-upstream origin backport/backport-15290-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15290-to-2.x.

mgodwan added a commit to mgodwan/OpenSearch that referenced this pull request Aug 30, 2024
* Create Index using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
mgodwan added a commit to mgodwan/OpenSearch that referenced this pull request Aug 30, 2024
* Create Index using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
mgodwan added a commit to mgodwan/OpenSearch that referenced this pull request Aug 30, 2024
* Create Index using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
mgodwan added a commit to mgodwan/OpenSearch that referenced this pull request Aug 30, 2024
* Create Index using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
mgodwan added a commit to mgodwan/OpenSearch that referenced this pull request Sep 1, 2024
* Create Index using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
shwetathareja pushed a commit that referenced this pull request Sep 2, 2024
* Create Index using context (#15290)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
* Create Index using context

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments backport 2.x Backport to 2.x branch backport-failed discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request feature New feature or request Indexing Indexing, Bulk Indexing and anything related to indexing RFC Issues requesting major changes Roadmap:Ease of Use Project-wide roadmap label v2.16.0 Issues and PRs related to version 2.16.0 v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Application Based Configuration Templates
5 participants